Lunny Xiao
5ffd1e04ef
Fix send mail bug ( #35834 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
backport #35833
2025-11-03 11:33:34 -08:00
Lunny Xiao
ac69bf8ab9
upgrade go mail ( #35752 )
...
backport #35748
2025-10-27 09:59:50 -07:00
Lunny Xiao
99053ce4fa
Change log for 1.24.7 ( #35742 )
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
2025-10-24 17:46:26 -07:00
wxiaoguang
e818de179e
Refactor legacy code ( #35708 ) ( #35713 )
...
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
Backport #35708
2025-10-21 09:10:10 +08:00
Giteabot
0a87bf9016
Fixing issue #35530 : Password Leak in Log Messages ( #35584 ) ( #35665 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
Backport #35584 by @shashank-netapp
# Summary
The Gitea codebase was logging `Elasticsearch` and `Meilisearch`
connection strings directly to log files without sanitizing them. Since
connection strings often contain credentials in the format
`protocol://username:password@host:port`, this resulted in passwords
being exposed in plain text in log output.
Fix:
- wrapped all instances of setting.Indexer.RepoConnStr and
setting.Indexer.IssueConnStr with the `util.SanitizeCredentialURLs()`
function before logging them.
Fixes : #35530
Co-authored-by: shashank-netapp <108022276+shashank-netapp@users.noreply.github.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2025-10-15 09:39:33 +00:00
Giteabot
86d99e2f38
Mock external service in hcaptcha TestCaptcha ( #35604 ) ( #35663 )
...
Backport #35604 by @silverwind
The test calls out to a web service which may be down or unreachable as
seen in the linked issue. It's better for tests to not have such
external dependencies to make them absolutely stable.
Fixes: https://github.com/go-gitea/gitea/issues/35571
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2025-10-15 08:49:24 +00:00
Giteabot
7bfb7567b2
Correctly override user unitmodes ( #35501 ) ( #35666 )
...
Backport #35501 by lynxplay
2025-10-15 08:22:59 +00:00
Giteabot
7619808137
Fix inputing review comment will remove reviewer ( #35591 ) ( #35664 )
...
Backport #35591 by @lunny
Fix #34617
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2025-10-15 07:56:52 +00:00
Giteabot
b854930a96
Fix a bug missed return ( #35655 ) ( #35671 )
...
Backport #35655 by @lunny
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2025-10-15 07:30:46 +00:00
Lunny Xiao
935f5e0ad5
Fix build ( #35669 )
...
backport #35656
2025-10-15 08:20:00 +02:00
Lunny Xiao
08c6ea6728
Changelog for 1.24.6 ( #35457 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
Signed-off-by: techknowlogick <matti@mdranta.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2025-09-10 20:45:54 -07:00
Giteabot
67977f0b1c
Fix a compare page 404 bug when the pull request disabled ( #35441 ) ( #35453 )
...
Backport #35441 by @lunny
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2025-09-10 22:39:50 +08:00
Lunny Xiao
78fbcf35ad
Fix push commits comments when changing the pull request target branch ( #35386 ) ( #35443 )
...
release-nightly / nightly-binary (push) Waiting to run
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run
Backport #35386
When changing the pull request target branch, the pushed commits
comments will not be changed resulted the number are inconsistent
between commits tab number and the pushed commits comments number.
This PR will remove all the previous pushed commits comments and
calculate new comments when changing the target branch.
Before:
<img width="928" height="585" alt="image"
src="https://github.com/user-attachments/assets/35e4d31f-31a1-4d14-83b0-1786721ab0d9 "
/>
After:
<img width="816" height="623" alt="image"
src="https://github.com/user-attachments/assets/24b6dafe-9238-4e7e-833d-68472457afab "
/>
2025-09-10 03:26:39 +02:00
Giteabot
8f5b1d27d4
Fix bug when issue disabled, pull request number in the commit message cannot be redirected ( #35420 ) ( #35442 )
...
Backport #35420 by @lunny
Fix #35419
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2025-09-09 20:09:24 +00:00
Giteabot
89c99a4dcb
fix: add author.name field to Swift Package Registry API response ( #35410 ) ( #35431 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
Backport #35410 by ahanoff
Fixes #35159
Swift Package Manager expects an 'author.name' field in package
metadata, but Gitea was only providing schema.org format fields
(givenName, middleName, familyName). This caused SPM to fail with
keyNotFound error when fetching package metadata.
Changes:
- Add 'name' field to Person struct (inherited from
https://schema.org/Thing )
- Populate 'name' field in API response using existing String() method
- Maintains backward compatibility with existing schema.org fields
- Provides both formats for maximum compatibility
The fix ensures Swift Package Manager can successfully resolve packages
while preserving full schema.org compliance.
Co-authored-by: Akhan Zhakiyanov <ahanoff@gmail.com>
2025-09-08 03:37:53 +08:00
Giteabot
3c7e7a19dd
fix(webhook/discord): fixed username cannot be empty error ( #35412 ) ( #35417 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
Backport #35412 by @ulnanlu
username field is not required by discord and used to override the
default username. sending it as blank causes a 400 error. it should be
omitted instead when it's not set.
Ref:
https://discord.com/developers/docs/resources/webhook#execute-webhook-jsonform-params
Closes #35411
Co-authored-by: ulnanlu <220980518+ulnanlu@users.noreply.github.com>
2025-09-05 18:44:39 +00:00
Giteabot
8313b5d998
Switch bitnami images to bitnamilegacy on CI ( #35402 ) ( #35403 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
Backport #35402 by @silverwind
As per https://github.com/bitnami/containers/issues/83267 , my
understanding is that the `docker.io/bitnami` images will be deleted on
September 29.
To prevent this failure mode, use the images on the `bitnamilegacy` org
instead which are snapshots from when they stopped updating them.
Long-term, we should replace these images with official ones.
Co-authored-by: silverwind <me@silverwind.io>
2025-09-03 23:15:50 +08:00
Lunny Xiao
6ca73bf662
Upgrade xz to v0.5.15 ( #35385 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
backport #35377
2025-08-30 10:47:34 -07:00
Lunny Xiao
5e10def7f7
Fix review request webhook bug ( #35339 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
partially backport #35337
Fix #35327
2025-08-28 21:26:29 -07:00
Giteabot
1b8efb6fc7
Allow foreachref parser to grow its buffer ( #35365 ) ( #35376 )
...
Backport #35365 by meyfa-lawo
Signed-off-by: Fabian Meyer <fabian.meyer@lawo.com>
Co-authored-by: Fabian Meyer <fabian.meyer@lawo.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2025-08-29 10:29:34 +08:00
Giteabot
8f89e1e174
Fix atom/rss mixed error ( #35345 ) ( #35347 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
Backport #35345 by @lunny
Fix #35342
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2025-08-26 01:38:36 +00:00
Giteabot
cbc595b9d9
Allow deleting comment with content via API like web did ( #35346 ) ( #35354 )
...
Backport #35346 by @lunny
Fix #35296
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2025-08-25 09:29:44 -07:00
Lunny Xiao
cc5ccf44dc
fix: remove duplicate IDs ( #35210 ) ( #35325 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
backport #35210
2025-08-22 16:19:55 -07:00
Lunny Xiao
f91e35b8b7
Upgrade mermaid to 11.10.0 ( #35333 )
...
backport #35329
2025-08-22 18:26:23 -04:00
Giteabot
f52ed422dc
Fix some overflows in test ( #35315 ) ( #35321 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
Backport #35315 by @lunny
Fix #35311
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2025-08-20 09:48:13 -07:00
Giteabot
0266ee5de7
Fix LFS range size header response ( #35277 ) ( #35293 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
Backport #35277 by @LePau
Fix #35276
Signed-off-by: LePau <101608950+LePau@users.noreply.github.com>
Co-authored-by: LePau <101608950+LePau@users.noreply.github.com>
2025-08-17 15:59:03 +03:00
Giteabot
ac03e65cf4
Fix GitHub release assets URL validation ( #35287 ) ( #35290 )
...
release-nightly / nightly-binary (push) Waiting to run
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run
Backport #35287 by @alexblackie
GitHub changed where the attachments on releases are stored, which means
repo migrations with releases now fail because the redirect URLs don't
match the base URL validation. We need to update the base URL check to
check for the `release-assets` subdomain as well.
Co-authored-by: Alex Blackie <alex@blackie.ca>
2025-08-15 19:43:59 -07:00
Giteabot
f3e6672c09
Fix token lifetime, closes #35230 ( #35271 ) ( #35281 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
Backport #35271 by @TimB87
This is an attempt to fix #35230 as discussed in the ticket.
Co-authored-by: Tim Biermann <tbier@posteo.de>
2025-08-14 14:52:09 -07:00
Lunny Xiao
136ec9ef81
Add changelog for 1.24.5 ( #35261 )
release-nightly / nightly-binary (push) Waiting to run
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run
2025-08-13 08:58:05 -07:00
Giteabot
79018ae726
modules/setting/actions.go: fixed typo: ì->i ( #35253 ) ( #35254 )
...
release-nightly / nightly-binary (push) Waiting to run
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run
Backport #35253 by @TimB87
Hello,
I spotted this minor typo.
Co-authored-by: Tim Biermann <tbier@posteo.de>
2025-08-12 11:21:56 +00:00
Giteabot
e11176192a
Fix a bug where lfs gc never worked. ( #35198 ) ( #35255 )
...
Backport #35198 by @lunny
Fix #31113
After #22385 introduced LFS GC, it never worked due to a bug in the INI
library: fields in structs embedded more than one level deep are not
populated from the INI file.
This PR fixes the issue by replacing the multi-level embedded struct
with a single-level struct for parsing the cron.gc_lfs configuration.
Added a new test for retrieving cron settings to demonstrate the bug in
the INI package.
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2025-08-12 10:57:50 +03:00
Giteabot
4e0269e890
Reload issue when sending webhook to make num comments is right. ( #35243 ) ( #35248 )
...
release-nightly / nightly-binary (push) Waiting to run
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run
Backport #35243 by @lunny
Fix #35229
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2025-08-11 10:12:47 -07:00
Lunny Xiao
04114c637a
Fix bug when review pull request commits ( #35192 ) ( #35246 )
...
The commit range in the UI follows a half-open, half-closed convention:
(,]. When reviewing a range of commits, the beforeCommitID should be set
to the commit immediately preceding the first selected commit. For
single-commit reviews, we must identify and use the previous commit of
that specific commit.
The endpoint ViewPullFilesStartingFromCommit is currently unused and can
be safely removed.
Fix #35157
Replace #35184
Partially extract from #35077
Backport #35192
2025-08-11 13:18:03 +02:00
6543
e5540bfa81
Nix flake build static with sqlite support ( #35149 ) ( #35225 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
Backport #35149
with `nix develop -c $SHELL` you can enter the dev environment. now with
`make clean-all generate build -j1` you will get a static linked binary
that has sqlite support
outside of an nix dev shell if you set `STATIC=true` you also will get a
static binary
2025-08-07 23:37:46 +03:00
Giteabot
d22d6ca0d8
Vertically center "Show Resolved" ( #35211 ) ( #35218 )
...
release-nightly / nightly-docker-rootless (push) Has been cancelled
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
Backport #35211 by @silverwind
Before, "Show Resolved" slightly off-center:
<img width="174" height="60" alt="Screenshot 2025-08-04 at 15 07 13"
src="https://github.com/user-attachments/assets/a165f721-4749-4ea3-bde0-141ad43a6142 "
/>
After: centered:
<img width="176" height="63" alt="Screenshot 2025-08-04 at 15 07 22"
src="https://github.com/user-attachments/assets/f87e16bc-d067-4040-b940-9adb4cf182c1 "
/>
Co-authored-by: silverwind <me@silverwind.io>
2025-08-06 10:55:48 +02:00
Lunny Xiao
d49feab428
release notes for 1.24.4 ( #35208 )
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
2025-08-04 11:13:27 -07:00
wxiaoguang
9162f4403a
Fix various bugs (1.24) ( #35186 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
Backport #35177 , #35183
2025-07-31 12:04:47 +08:00
Giteabot
d05cf08fad
Fix migrate input box bug ( #35166 ) ( #35171 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
Backport #35166 by @lunny
Fix #35162
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2025-07-27 19:57:47 -07:00
Giteabot
f4b4b0bf98
Only hide dropzone when no files have been uploaded ( #35156 ) ( #35167 )
...
release-nightly / nightly-binary (push) Waiting to run
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run
Backport #35156 by @bartvdbraak
Instead of always hiding the dropzone when it's not active:
- hide it when when there are no uploaded files and it becomes inactive
- don't hide it when there are uploaded files
Fixes #35125
Co-authored-by: Bart van der Braak <bartvdbraak@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2025-07-27 11:20:48 +03:00
wxiaoguang
99596044d7
Don't use full-file highlight when there is a git diff textconv ( #35114 ) ( #35119 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
Fix #35106
2025-07-18 13:52:41 +00:00
Giteabot
693d26914f
Fix submodule parsing when the gitmodules is missing ( #35109 ) ( #35118 )
...
Backport #35109
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2025-07-18 20:22:18 +08:00
Giteabot
315f197790
Increase gap on latest commit ( #35104 ) ( #35113 )
...
release-nightly / nightly-binary (push) Waiting to run
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run
Backport #35104 by @silverwind
Before:
<img width="964" height="101" alt="Screenshot 2025-07-17 at 02 31 05"
src="https://github.com/user-attachments/assets/e02181f3-f730-40bb-8cfa-ecfea4ed4aec "
/>
After:
<img width="967" height="104" alt="Screenshot 2025-07-17 at 02 42 13"
src="https://github.com/user-attachments/assets/7ca7b9a8-1f59-4dc0-9bb0-c72346fd792a "
/>
Co-authored-by: silverwind <me@silverwind.io>
2025-07-18 08:25:51 +03:00
Giteabot
76b8f0c3a7
Fix review comment/dimiss comment x reference can be refereced back ( #35094 ) ( #35099 )
release-nightly / nightly-binary (push) Waiting to run
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run
2025-07-17 00:04:05 +08:00
Giteabot
f99bbd7f3f
Fix submodule nil check ( #35096 ) ( #35098 )
...
Backport #35096 by wxiaoguang
Fix #35095
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2025-07-16 13:02:18 +00:00
Giteabot
f7ef657b5a
nix flake update ( #35085 ) ( #35090 )
...
release-nightly / nightly-binary (push) Waiting to run
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run
Backport #35085 by @techknowlogick
Co-authored-by: techknowlogick <techknowlogick@gitea.com>
2025-07-15 14:37:44 -07:00
Lunny Xiao
486d274be6
Add missing changelog ( #35079 )
...
release-nightly / nightly-binary (push) Waiting to run
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2025-07-15 12:08:13 +08:00
Giteabot
ab3d2a944c
Fix form property assignment edge case ( #35073 ) ( #35078 )
...
Backport #35073 by wxiaoguang
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2025-07-15 09:40:50 +08:00
wxiaoguang
12bfa9e83d
Improve submodule relative path handling ( #35056 ) ( #35075 )
...
Backport #35056
2025-07-14 17:26:16 +00:00
Giteabot
dd661e92df
Fix incorrect comment diff hunk parsing, fix github asset ID nil panic ( #35046 ) ( #35055 )
...
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
Backport #35046 by lunny
* Fix missing the first char when parsing diff hunk header
* Fix #35040
* Fix #35049
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2025-07-12 15:12:02 +08:00
Giteabot
0b31272c7e
Fix updating user visibility ( #35036 ) ( #35044 )
...
release-nightly / nightly-binary (push) Waiting to run
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run
Backport #35036 by @lunny
Fix #35030
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2025-07-11 02:44:06 +00:00